Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the snapshots #2197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update the snapshots #2197

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ffa7c6
Update the snapshots and remove yamlDefinedResources
Mar 21, 2024
4f5a8c6
Use java 21
tomrf1 Mar 22, 2024
c8509fe
update snap
tomrf1 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cdk/lib/__snapshots__/stripe-webhook-endpoints.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1717,7 +1717,7 @@ exports[`The StripeWebhookEndpoints stack matches the snapshot 2`] = `
],
},
],
"Runtime": "java11",
"Runtime": "java21",
"Tags": {
"Stack": "support",
"Stage": "PROD",
Expand Down Expand Up @@ -1808,7 +1808,7 @@ exports[`The StripeWebhookEndpoints stack matches the snapshot 2`] = `
],
},
],
"Runtime": "java11",
"Runtime": "java21",
"Tags": {
"Stack": "support",
"Stage": "PROD",
Expand Down
6 changes: 3 additions & 3 deletions cdk/lib/stripe-webhook-endpoints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class StripeWebhookEndpoints extends GuStack {

// ---- Existing CFN template ---- //
const yamlTemplateFilePath = path.join(__dirname, "../..", "handlers/stripe-webhook-endpoints/cfn.yaml");
const yamlDefinedResources = new CfnInclude(this, "YamlTemplate", {
new CfnInclude(this, "YamlTemplate", {
templateFile: yamlTemplateFilePath,
});

Expand All @@ -43,7 +43,7 @@ export class StripeWebhookEndpoints extends GuStack {
functionName: `stripe-payment-intent-issues-cdk-${this.stage}`,
fileName: `${app}.jar`,
handler: "com.gu.paymentIntentIssues.Lambda::handler",
runtime: Runtime.JAVA_11,
runtime: Runtime.JAVA_21,
Copy link
Member

@tomrf1 tomrf1 Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it consistent with the recent change to the legacy cfn.yaml

memorySize: 512,
timeout: Duration.seconds(300),
environment: {
Expand All @@ -61,7 +61,7 @@ export class StripeWebhookEndpoints extends GuStack {
functionName: `stripe-customer-updated-cdk-${this.stage}`,
fileName: `${app}.jar`,
handler: "com.gu.stripeCardUpdated.Lambda::apply",
runtime: Runtime.JAVA_11,
runtime: Runtime.JAVA_21,
memorySize: 1536,
timeout: Duration.seconds(900),
environment: {
Expand Down
Loading