Replace all when handling + in emails (#258)

* Replace all when handling + in emails

* update test

src/create-reminder-signup/lambda/models.test.ts

@@ -91,12 +91,12 @@ describe('request validation', () => {
 	it('transforms an email address containing a space', () => {
 		// Identity’s guest creation endpoint errors if the provided email address is more than 100 characters long
 		// See baseSignupRequestSchema definition for details
-		const email = 'test afterplus@theguardian.com';
+		const email = 'test after plus@theguardian.com';
 		const result = oneOffSignupRequestSchema.safeParse({
 			...oneOffSignupRequest,
 			email,
 		});
 		expect(result.success).toBe(true);
-		expect(result.data?.email).toBe('test+afterplus@theguardian.com');
+		expect(result.data?.email).toBe('test+after+plus@theguardian.com');
 	});
 });

src/create-reminder-signup/lambda/models.ts

@@ -52,7 +52,7 @@ export const baseSignupRequestSchema = z.object({
 		// Identity’s guest creation endpoint errors if the provided email address is more than 100 characters long
 		.max(100)
 		// The API gateway -> SQS integration encodes + as a space in the email string
-		.transform((email) => email.replace(' ', '+'))
+		.transform((email) => email.replace(/ /g, '+'))
 		.pipe(z.string().email()),
 	country: z.string().optional(),
 	reminderCreatedAt: z.string().datetime().optional(),

src/lib/identity.ts

@@ -12,7 +12,7 @@ export const idapiBaseUrl = isProd()
 	: 'https://idapi.code.dev-theguardian.com';
 
 const encodeEmail = (email: string): string =>
-	encodeURI(email).replace('+', '%2B');
+	encodeURI(email).replace(/\+/g, '%2B');
 
 export interface IdentitySuccess {
 	name: 'success';