-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browserslist packages #6725
Merged
Merged
+9
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran: $ npx update-browserslist-db@latest This reported "No target browser changes" so I don't think anything has changed. But it should silence some warnings we're seeing: Browserslist: caniuse-lite is outdated.
Size Change: 0 B Total Size: 2.35 MB ℹ️ View Unchanged
|
andrewHEguardian
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice
Seen on PROD (merged by @tjmw 9 minutes and 55 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
This updates the
@guardian/browserslist
package version and also thecaniuse-lite
db which contains browser stats. These are used in combination withpreset-env
to determine the code to be generated by babel. When I ran the upgrade I saw the following log line:No target browser changes
. So I don't think this actually changes anything regarding the browsers we're targeting.Update: I actually don't think we use caniuse-lite at all since
@guardian/browserslist-config
contains its own stats pulled from our GA data. We can see that this PR doesn't change any bundle sizes at all, so I think that confirms this upgrade is essentially a no-op.Why are you doing this?
We see the following warnings in local dev and CI:
How to test
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots