Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browserslist packages #6725

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Update browserslist packages #6725

merged 2 commits into from
Jan 24, 2025

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jan 24, 2025

What are you doing in this PR?

This updates the @guardian/browserslist package version and also the caniuse-lite db which contains browser stats. These are used in combination with preset-env to determine the code to be generated by babel. When I ran the upgrade I saw the following log line: No target browser changes. So I don't think this actually changes anything regarding the browsers we're targeting.

Update: I actually don't think we use caniuse-lite at all since @guardian/browserslist-config contains its own stats pulled from our GA data. We can see that this PR doesn't change any bundle sizes at all, so I think that confirms this upgrade is essentially a no-op.

Why are you doing this?

We see the following warnings in local dev and CI:

Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

How to test

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

tjmw added 2 commits January 24, 2025 09:59
I ran:

$ npx update-browserslist-db@latest

This reported "No target browser changes" so I don't think anything has
changed. But it should silence some warnings we're seeing:

Browserslist: caniuse-lite is outdated.
Copy link
Contributor

Size Change: 0 B

Total Size: 2.35 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 93.2 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 254 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB
./public/compiled-assets/javascripts/error404Page.js 67.3 kB
./public/compiled-assets/javascripts/error500Page.js 67.2 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/186.js 3.35 kB
./public/compiled-assets/webpack/187.js 20.1 kB
./public/compiled-assets/webpack/3.js 19.2 kB
./public/compiled-assets/webpack/311.js 40.1 kB
./public/compiled-assets/webpack/344.js 2.01 kB
./public/compiled-assets/webpack/397.js 10.2 kB
./public/compiled-assets/webpack/426.js 36.6 kB
./public/compiled-assets/webpack/706.js 107 kB
./public/compiled-assets/webpack/719.js 13.5 kB
./public/compiled-assets/webpack/754.js 9.92 kB
./public/compiled-assets/webpack/847.js 26 kB
./public/compiled-assets/webpack/checkout.js 14.3 kB
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.05 kB
./public/compiled-assets/webpack/oneTimeCheckout.js 10 kB
./public/compiled-assets/webpack/ThankYou.js 1.08 kB

compressed-size-action

Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@tjmw tjmw merged commit 7a2cf36 into main Jan 24, 2025
19 checks passed
@tjmw tjmw deleted the tw/browserslist branch January 24, 2025 10:46
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 9 minutes and 55 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants