-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guardian Ad-Lite backend rename #6700
Conversation
Includes the cookie and email IDs, which will need to be reflected elsewhere.
Size Change: -16 B (0%) Total Size: 2.39 MB ℹ️ View Unchanged
|
I've also removed the contribution param, which I don't think is needed or used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I think 👍
support-frontend/assets/pages/[countryGroupId]/guardianAdLiteLanding/components/headerCards.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. the GuardianLight playwright test fail to checkout as its all updated to GuardianAdLite as you mention in start of PR. Just checking removal of contribution from the checkout url?
Thanks @paul-daniel-dempsey!
Oh - I've update the e2e tests in this PR. If you run the playwright tests locally (against your local env) they should work. When I deployed to CODE and ran |
Seen on PROD (merged by @tjmw 9 minutes and 55 seconds ago)
Sentry Release: support-client-side, support |
What are you doing in this PR?
This PR updates the backend and support-workers code to handle the new product
Guardian Ad-Lite
. I've done this as a rename, so after this PR is merged GuardianLight purchases will no longer work (even though the client will continue handling GuardianLight until it's removed).This means the playwright tests will need updating before merging this.Done.Changes which have an impact outside of this codebase:
Trello Card
Now that the backend supports
GuardianAdLite
(and no longer supportsGuardianLight
) I've moved over some final references in the frontend to use the new product name, e.g. we now link from the landing page to the checkout with the new product ID.Why are you doing this?
The product name has changed, this follows on from #6692 to move the support site over to the newly named product.
How to test
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots