Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardian Ad-Lite backend rename #6700

Merged
merged 7 commits into from
Jan 20, 2025
Merged

Guardian Ad-Lite backend rename #6700

merged 7 commits into from
Jan 20, 2025

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jan 16, 2025

What are you doing in this PR?

This PR updates the backend and support-workers code to handle the new product Guardian Ad-Lite. I've done this as a rename, so after this PR is merged GuardianLight purchases will no longer work (even though the client will continue handling GuardianLight until it's removed). This means the playwright tests will need updating before merging this. Done.

Changes which have an impact outside of this codebase:

  • The cookie dropped has been renamed - communicate this to affected teams.
  • The email IDs have changed, so will need updating in membership-workflow (https://github.com/guardian/membership-workflow/pull/572 - should be deployed at the same time).
  • The acquisition ID has changed - communicate this to affected teams.

Trello Card

Now that the backend supports GuardianAdLite (and no longer supports GuardianLight) I've moved over some final references in the frontend to use the new product name, e.g. we now link from the landing page to the checkout with the new product ID.

Why are you doing this?

The product name has changed, this follows on from #6692 to move the support site over to the newly named product.

How to test

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

tjmw added 3 commits January 16, 2025 12:36
Includes the cookie and email IDs, which will need to be reflected
elsewhere.
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Size Change: -16 B (0%)

Total Size: 2.39 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.5 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 93.3 kB +1 B (0%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 259 kB 0 B
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 228 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.7 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.6 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.5 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 166 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 88 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 66.1 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.9 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.2 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 227 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 163 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.1 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 21.8 kB 0 B
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/311.js 40.1 kB +13 B (+0.03%)
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/397.js 10.2 kB 0 B
./public/compiled-assets/webpack/426.js 41 kB 0 B
./public/compiled-assets/webpack/643.js 22.4 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/754.js 9.97 kB -1 B (-0.01%)
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 14.3 kB +5 B (+0.03%)
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.05 kB -34 B (-0.37%)
./public/compiled-assets/webpack/oneTimeCheckout.js 9.97 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 1.07 kB 0 B

compressed-size-action

Copy link
Member

@rupertbates rupertbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think 👍

@tjmw tjmw marked this pull request as ready for review January 17, 2025 09:52
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. the GuardianLight playwright test fail to checkout as its all updated to GuardianAdLite as you mention in start of PR. Just checking removal of contribution from the checkout url?

@tjmw
Copy link
Member Author

tjmw commented Jan 17, 2025

Thanks @paul-daniel-dempsey!

the GuardianLight playwright test fail to checkout as its all updated to GuardianAdLite

Oh - I've update the e2e tests in this PR. If you run the playwright tests locally (against your local env) they should work. When I deployed to CODE and ran yarn test-smoke-ui-code they passed.

@tjmw tjmw merged commit 906b562 into main Jan 20, 2025
19 checks passed
@tjmw tjmw deleted the tw/guardian-ad-lite-backend branch January 20, 2025 10:15
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 9 minutes and 55 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants