Delete Old Supporter Plus Checkout #6682
Conversation
|
Size Change: -74.7 kB (-3.41%) Total Size: 2.12 MB
ℹ️ View Unchanged
|
|
We should be aware that we no longer have any Storybook coverage of thank you pages |
| @@ -349,7 +349,7 @@ class Application( | |||
| id = s"contributions-landing-page-$countryCode", | |||
| mainElement = mainElement, | |||
| js = RefPath("supporterPlusLandingPage.js"), | |||
| css = Some(RefPath("supporterPlusLandingPage.css")), | |||
| css = None, | |||
There was a problem hiding this comment.
It looks like the file deletion has removed any sass being created on this page, so the asset is missing when the controller tries to find it
| @@ -9,7 +9,6 @@ export const { | |||
| setProductPrices, | |||
| setAllAmounts, | |||
| setSelectedAmount, | |||
| setCoverTransactionCost, | |||
There was a problem hiding this comment.
Could this come out of the corresponding reducer.ts file?
There was a problem hiding this comment.
It could, but I figured it was a marginal gain to remove it and it will come out when we delete most of the redux
| export const { | ||
| setIsReturningContributor, | ||
| setIsSignedIn, | ||
| setStorybookUser, |
There was a problem hiding this comment.
Can ths come out the reducer too?
| @@ -60,6 +61,8 @@ export function ThankYou({ geoId, appConfig }: ThankYouProps) { | |||
| originalAmount: finalAmount, | |||
| finalAmount: finalAmount, | |||
| }; | |||
|
|
|||
| setHideSupportMessagingCookie(); | |||
There was a problem hiding this comment.
Is this part of this PR specifically? If not, maybe a comment might be good here?
There was a problem hiding this comment.
It's part of this PR because the deletion of the old thank you page highlighted we didn't port this across
| import ThankYouHeader from './components/thankYouHeader'; | ||
|
|
||
| const checkoutContainer = css` |
There was a problem hiding this comment.
Great idea to move this across
| @@ -78,16 +75,6 @@ const router = () => { | |||
| ) | |||
| } | |||
| /> | |||
| <Route | |||
There was a problem hiding this comment.
Nice removal 👌
|
Seen on PROD (merged by @andrewHEguardian 11 minutes and 4 seconds ago)
Sentry Release: support-client-side, support |
What are you doing in this PR?
Deleting the supporter plus checkout and thank you page (the old redux version) and the files and functions used only by them.
Trello Card
Why are you doing this?
No acqusitions have been made via
twoStepPages/secondStepCheckout.tsxsince #6596 should be sending any traffic that previously went to the “/contribute/checkout” route to the new generic / one-time checkouts nowHow to test
gu_hide_support_messagingis set on the one time thank you page