Knip - Production mode #6676
Merged
Knip - Production mode #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -24 B (0%) Total Size: 2.19 MB ℹ️ View Unchanged
|
tjmw
approved these changes
Jan 7, 2025
| @@ -1,11 +1,11 @@ | |||
| const entryPoints = require('../webpack.entryPoints').common; | |||
|
|
|||
| const flattenedEntryPoints = [...Object.keys(entryPoints)].map( | |||
| (key) => `assets/${entryPoints[key]}`, | |||
| (key) => `assets/${entryPoints[key]}!`, | |||
There was a problem hiding this comment.
So the ! here is a signal to knip that this is production code?
There was a problem hiding this comment.
Exactly, is it worth a comment or link?
There was a problem hiding this comment.
Yeah I think a comment/link would be good 👍
|
Seen on PROD (merged by @andrewHEguardian 9 minutes and 42 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Remove unused code found using knip in production mode, and add our entry points as the production code using the
!syntax. This reveals code used only by tests, obviously some of these are necessary (eg mocks) so we shouldn't run our GHA in production mode.How to test
Run
yarn knip --production- see files and dependencies used by tests