Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send consent to Ophan #6644

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Send consent to Ophan #6644

merged 4 commits into from
Jan 6, 2025

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented Dec 19, 2024

What are you doing in this PR?

Sending consent data to Ophan upload receiving first consent.

Why are you doing this?

Improve Ophan tracking

Tested in CODE

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Size Change: +3.24 kB (+0.14%)

Total Size: 2.24 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB +237 B (+0.26%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 266 kB +81 B (+0.03%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 236 kB +246 B (+0.1%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 70.9 kB +187 B (+0.26%)
./public/compiled-assets/javascripts/error404Page.js 70.8 kB +186 B (+0.26%)
./public/compiled-assets/javascripts/error500Page.js 70.8 kB +185 B (+0.26%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 175 kB +271 B (+0.16%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.7 kB +237 B (+0.27%)
./public/compiled-assets/javascripts/payPalErrorPage.js 69.2 kB +204 B (+0.3%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.8 kB +188 B (+0.26%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.1 kB +187 B (+0.26%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 127 kB +246 B (+0.19%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 308 kB +275 B (+0.09%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 172 kB +269 B (+0.16%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 87.9 kB +237 B (+0.27%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.6 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/643.js 22.4 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

@akinsola-guardian akinsola-guardian marked this pull request as ready for review December 19, 2024 15:26
Copy link
Member

@rupertbates rupertbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worth waiting till after Christmas to release?

@akinsola-guardian akinsola-guardian added the Do Not Merge May still be WIP or unstable label Dec 19, 2024
@akinsola-guardian akinsola-guardian removed the Do Not Merge May still be WIP or unstable label Jan 6, 2025
@akinsola-guardian akinsola-guardian merged commit 27493d5 into main Jan 6, 2025
19 checks passed
@akinsola-guardian akinsola-guardian deleted the al-send-consent-to-ophan branch January 6, 2025 14:57
@prout-bot
Copy link

Seen on PROD (merged by @akinsola-guardian 9 minutes and 40 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants