Use react router for landing => checkout => thank-you route #5962
Conversation
| const router = createBrowserRouter( | ||
| geoIds | ||
| .map((geoId) => [ | ||
| { |
There was a problem hiding this comment.
We'll add the /${geoId} soon as part of the migration from /{geoId}/contribute work as this URL is currently redirected via Fastly and the Play app.
|
Size Change: +14.9 kB (+1%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
| ssrPages: 'helpers/rendering/ssrPages.ts', | ||
| }, | ||
| common: { | ||
| '[countryGroupId]/router': 'pages/[countryGroupId]/router.tsx', |
There was a problem hiding this comment.
This is the change - the rest is formatting.
| type Props = { | ||
| geoId: GeoId; | ||
| }; | ||
| function CheckoutComponent({ geoId }: Props) { |
There was a problem hiding this comment.
The ordering of this file has changed - that's provably the most important piece to review.
|
@GHaberis - re: filesize - currently It's not a fair comparison though as Interestingly - adding As a point, another reason I am not going to deep on exploring other routers is we have quite a few methods that use react-router with pageviews and the like. |
jamesgorrie
force-pushed
the
react-router-thank-you
branch
2 times, most recently
from
fd637fd to
498acd7
Compare
jamesgorrie
force-pushed
the
react-router-thank-you
branch
from
498acd7 to
da2a059
Compare
|
Seen on PROD (merged by @jamesgorrie 9 minutes and 49 seconds ago)
Sentry Release: support-client-side, support |
react-routerto encapsulate thelanding => checkout => thank-youjourneyGeoIdConfigwhich is config that is variable on the/{geoId}segment of the URLcheckoutname for the route torouterin the play appgeoIdin the checkout component into the componentI'm doing this because when setting up a whole new route for the thank you page from Play => rendering, the boilerplate was becoming immense and unwieldy. This replicates the pattern we had setup for
/{geoId}/contributionfrom Play => Router.This also avoids having to spin up another
webpack.entryPoint. A 🚤 performance-point 🚀 herePart of #5722
Tasks