-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feast IAP acquisition support #5960
Open
tjmw
wants to merge
2
commits into
main
Choose a base branch
from
tw/add-feast-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.94 MB ℹ️ View Unchanged
|
The mobile-purchases codebase is going to be adding items to the event bus when IAP acquisitions occur for Feast.
tjmw
changed the title
Add Feast App to acquisition products
Add Feast IAP acquisition support
Apr 26, 2024
tomrf1
approved these changes
Apr 26, 2024
rupertbates
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Currently Feast IAPs are missing from the
fact_acquisition_event
table in the lake. The live apps do this by making requests from the device to the acquisitions API endpoint. For Feast we'd like to do this directly from the mobile-purchases estate, writing events directly to the event bus.This PR starts adding support for this. So far we have:
Trello Card
Why are you doing this?
How to test
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots