Generic Checkout: Invalid URL Param Price Checks #5955

paul-daniel-dempsey · 2024-04-23T15:30:59Z

What are you doing in this PR?

Missing functionality for the Generic Contributions Checkout

Contributions amounts greater than the SupporterPlus threshold within non-contribution-only countries should be marked as isInvalidAmount
https://support.thegulocal.com/uk/checkout?product=Contribution&ratePlan=Monthly&price=13

Contributions amounts less than than 1 should be marked as isInvalidAmount
https://support.thegulocal.com/uk/checkout?product=Contribution&ratePlan=Monthly&price=0.1

SupporterPlus amounts below the SupporterPlus threshold should be marked as isInvalidAmount
https://support.thegulocal.com/uk/checkout?product=SupporterPlus&ratePlan=Monthly&price=8

Trello Card

How to test

https://support.thegulocal.com/uk/contribute#ab-useGenericCheckout=variant

Part of #5722

…n suppoerter+ price in relevent countries

github-actions · 2024-04-23T15:52:38Z

Deploy build 9759 of `support::stripe-patrons-data` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2024-04-23T15:53:52Z

Size Change: 0 B

Total Size: 1.79 MB

ℹ️ View Unchanged

Filename	Size
`./public/compiled-assets/javascripts/ausMomentMap.js`	107 kB
`./public/compiled-assets/javascripts/contributionsRedirectStyles.js`	20 B
`./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js`	217 kB
`./public/compiled-assets/javascripts/downForMaintenancePage.js`	68 kB
`./public/compiled-assets/javascripts/error404Page.js`	68 kB
`./public/compiled-assets/javascripts/error500Page.js`	67.9 kB
`./public/compiled-assets/javascripts/favicons.js`	616 B
`./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js`	168 kB
`./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js`	84.8 kB
`./public/compiled-assets/javascripts/payPalErrorPage.js`	66.5 kB
`./public/compiled-assets/javascripts/payPalErrorPageStyles.js`	20 B
`./public/compiled-assets/javascripts/promotionTerms.js`	71.2 kB
`./public/compiled-assets/javascripts/subscriptionsLandingPage.js`	70.3 kB
`./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js`	124 kB
`./public/compiled-assets/javascripts/supporterPlusLandingPage.js`	284 kB
`./public/compiled-assets/javascripts/unsupportedBrowserStyles.js`	20 B
`./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js`	188 kB
`./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js`	85 kB
`./public/compiled-assets/webpack/363.js`	18.2 kB
`./public/compiled-assets/webpack/385.js`	81.8 kB
`./public/compiled-assets/webpack/735.js`	2 kB
`./public/compiled-assets/webpack/775.js`	18 kB
`./public/compiled-assets/webpack/991.js`	2.16 kB

_{compressed-size-action}

github-actions · 2024-04-23T15:54:00Z

Deploy build 19023 of `support:support-workers-mono` to CODE

All deployment options

From guardian/actions-riff-raff.

support-frontend/assets/pages/[countryGroupId]/checkout.tsx

jamesgorrie · 2024-04-24T09:08:09Z

support-frontend/assets/pages/[countryGroupId]/checkout.tsx

+	if (queryPrice < 1) {
+		isInvalidAmount = true;
+	}


Just to double check this - we don't allow e.g. 50p donations?

Think the above applies for Contributions

Happy for this to go in as is - but probably worth double checking as I'm not sure this is validated against anywhere else in the pipeline.

Pretty sure old S+ checkout guarded against this low entry, not sure how can check the pipeline. Will put in for now and we can revisit if necessary

Actually if you change the Contribution amount in the paramUrl for the current checkout to £0.1 it jumps you straight to the S+ product at £10! Think marking it as invalid is fine for moment.

jamesgorrie

Just a question on why we have the const queryPrice

prout-bot · 2024-04-24T11:58:01Z

Seen on PROD (merged by @paul-daniel-dempsey 10 minutes and 57 seconds ago)

Keep an eye out for post deployment test results on teamcity

Sentry Release: support-client-side, support

GHaberis · 2024-04-24T12:19:29Z

Contributions amounts greater than the SupporterPlus threshold within non-contribution-only countries should be marked as isInvalidAmount

@paul-daniel-dempsey we've recently begun allowing amounts at or above the S+ threshold for users where isContributionsOnlyCountry is true, however we regard them as Recurring Contributions rather than S+. Could we do this on this checkout too? The logic lives here https://github.com/guardian/support-frontend/blob/main/support-frontend/assets/helpers/redux/checkout/product/selectors/isSupporterPlus.ts#L14

jamesgorrie · 2024-04-24T13:05:21Z

@GHaberis from what I can tell in this PR @paul-daniel-dempsey has allowed exactly this by only checking it against the S+ amount if you are in contribution only countries here.

paul-daniel-dempsey · 2024-04-24T14:12:19Z

@GHaberis : we tested with Albania and it allowed a Contribution above the S+ threshold using: https://support.thegulocal.com/eu/checkout?country=AL&product=Contribution&ratePlan=Monthly&price=14

paul-daniel-dempsey added 4 commits April 23, 2024 16:14

feat: display param url price, check contribution price not lower tha…

1de02e6

…n suppoerter+ price in relevent countries

feat: param url check for S+ product amount not lower than S+ threshold

88c7b31

feat: param url check for Contribution amount > 1

f293197

Merge branch 'main' into generic-checkout-amounts-summary

3601da6

paul-daniel-dempsey requested a review from a team April 23, 2024 15:59

paul-daniel-dempsey and others added 2 commits April 23, 2024 17:06

fix: faster price check <1 ordered first, simplify S+ threshold price,

663d743

refactor: use price over amount

338254f

jamesgorrie reviewed Apr 24, 2024

View reviewed changes

support-frontend/assets/pages/[countryGroupId]/checkout.tsx Show resolved Hide resolved

jamesgorrie reviewed Apr 24, 2024

View reviewed changes

support-frontend/assets/pages/[countryGroupId]/checkout.tsx Outdated Show resolved Hide resolved

jamesgorrie reviewed Apr 24, 2024

View reviewed changes

jamesgorrie approved these changes Apr 24, 2024

View reviewed changes

review: unnecessary const queryPrice removed

de9fbf1

paul-daniel-dempsey changed the title ~~Generic Checkout: Invalid URL Param Amount Checks~~ Generic Checkout: Invalid URL Param Price Checks Apr 24, 2024

Merge branch 'main' into generic-checkout-amounts-summary

fb0d722

paul-daniel-dempsey merged commit cb51a83 into main Apr 24, 2024
15 checks passed

paul-daniel-dempsey deleted the generic-checkout-amounts-summary branch April 24, 2024 11:47

prout-bot added Pending-on-PROD Seen-on-PROD and removed Pending-on-PROD labels Apr 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generic Checkout: Invalid URL Param Price Checks #5955

Generic Checkout: Invalid URL Param Price Checks #5955

paul-daniel-dempsey commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

jamesgorrie Apr 24, 2024 •

edited

Loading

paul-daniel-dempsey Apr 24, 2024

paul-daniel-dempsey Apr 24, 2024

jamesgorrie Apr 24, 2024

paul-daniel-dempsey Apr 24, 2024 •

edited

Loading

paul-daniel-dempsey Apr 24, 2024

jamesgorrie left a comment

prout-bot commented Apr 24, 2024

GHaberis commented Apr 24, 2024 •

edited

Loading

jamesgorrie commented Apr 24, 2024

paul-daniel-dempsey commented Apr 24, 2024 •

edited

Loading

Generic Checkout: Invalid URL Param Price Checks #5955

Generic Checkout: Invalid URL Param Price Checks #5955

Conversation

paul-daniel-dempsey commented Apr 23, 2024 • edited Loading

What are you doing in this PR?

How to test

github-actions bot commented Apr 23, 2024 • edited Loading

Deploy build 9759 of support::stripe-patrons-data to CODE

github-actions bot commented Apr 23, 2024 • edited Loading

github-actions bot commented Apr 23, 2024 • edited Loading

Deploy build 19023 of support:support-workers-mono to CODE

jamesgorrie Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

paul-daniel-dempsey Apr 24, 2024

Choose a reason for hiding this comment

paul-daniel-dempsey Apr 24, 2024

Choose a reason for hiding this comment

jamesgorrie Apr 24, 2024

Choose a reason for hiding this comment

paul-daniel-dempsey Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

paul-daniel-dempsey Apr 24, 2024

Choose a reason for hiding this comment

jamesgorrie left a comment

Choose a reason for hiding this comment

prout-bot commented Apr 24, 2024

Sentry Release: support-client-side, support

GHaberis commented Apr 24, 2024 • edited Loading

jamesgorrie commented Apr 24, 2024

paul-daniel-dempsey commented Apr 24, 2024 • edited Loading

paul-daniel-dempsey commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

Deploy build 9759 of `support::stripe-patrons-data` to CODE

github-actions bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024 •

edited

Loading

Deploy build 19023 of `support:support-workers-mono` to CODE

jamesgorrie Apr 24, 2024 •

edited

Loading

paul-daniel-dempsey Apr 24, 2024 •

edited

Loading

GHaberis commented Apr 24, 2024 •

edited

Loading

paul-daniel-dempsey commented Apr 24, 2024 •

edited

Loading