Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Obligatron daily at 7AM #1078

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Run Obligatron daily at 7AM #1078

merged 2 commits into from
Jun 25, 2024

Conversation

AshCorr
Copy link
Member

@AshCorr AshCorr commented Jun 12, 2024

What does this change?

Run Obligatron daily at 7AM

Why?

So that we can start building a historical view and get an understanding of how much data there is (once we enable Security Hub on all accounts that is!)

How has it been verified?

Ran snapshot test.

@AshCorr AshCorr requested review from a team as code owners June 12, 2024 13:14
@akash1810
Copy link
Member

This is a cron method. Did we consider an event driven method, running the lambda once the task to collect the aws_securityhub_findings table completes?

Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment isn't blocking.

@AshCorr AshCorr force-pushed the ash/obligatron-schedule branch from 1ff8c2c to bc6ece1 Compare June 25, 2024 09:12
@AshCorr
Copy link
Member Author

AshCorr commented Jun 25, 2024

This is a cron method. Did we consider an event driven method, running the lambda once the task to collect the aws_securityhub_findings table completes?

I think that would be ideal, for the sake of building a base line lets do it daily for now though till we figure out how to link the Cloudquery jobs to this Lambda!

@AshCorr AshCorr enabled auto-merge June 25, 2024 09:13
@AshCorr AshCorr merged commit e7192bb into main Jun 25, 2024
4 checks passed
@AshCorr AshCorr deleted the ash/obligatron-schedule branch June 25, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants