-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add routing and split out home from feed #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to be a good incremental step forward! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see some familiar code! did we consider using a router library? I imagine it'll be easier to build one in from the start, than to migrate later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see some familiar code!
👍👍
did we consider using a router library? I imagine it'll be easier to build one in from the start, than to migrate later
we had a couple of chats about it, but no super concrete outcome so I thought it made sense to move forward with this for now as it's fairly narrowly scoped. fwiw judging from the spike I did with tanstack-router
for crosswordv2 I don't think that migrating to a library solution later should be too painful.
but happy to use one here if we're feeling confident that we'll want one at some point
What does this change?
Preliminary Refactors
Main feature
state.tsx
in the crosswordv2 app.How to test
/
shows the new landing page/feed
shows all wire results/feed?q=ipsum
loads filtered wire results/feed?q=[your search terms]
How can we measure success?
Have we considered potential risks?
Images
Landing page
Search terms are bound to the URL
Accessibility