Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newswires UI: add search summary #116

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Newswires UI: add search summary #116

merged 1 commit into from
Jan 29, 2025

Conversation

sb-dev
Copy link
Contributor

@sb-dev sb-dev commented Jan 28, 2025

What does this change?

Add search summary.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@sb-dev sb-dev requested a review from a team as a code owner January 28, 2025 17:47
@sb-dev sb-dev force-pushed the ui-search-summary branch 8 times, most recently from 5c7af48 to 1438908 Compare January 28, 2025 18:12
@sb-dev sb-dev force-pushed the ui-search-summary branch 2 times, most recently from cd98777 to 033d4e3 Compare January 29, 2025 10:43
const [freeTextQuery, setFreeTextQuery] = useState<string>(config.query.q);
const [freeTextQuery, setFreeTextQuery] = useState<string>('');

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

Copy link
Contributor

@bryophyta bryophyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! one small comment but not blocking 👍👍

@sb-dev sb-dev force-pushed the ui-search-summary branch from 033d4e3 to c614fb7 Compare January 29, 2025 11:55
@sb-dev sb-dev merged commit 2cf8af5 into main Jan 29, 2025
3 checks passed
@sb-dev sb-dev deleted the ui-search-summary branch January 29, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants