Merge pull request #88 from guardian/pf/fix-npm-linting

All workspaces should have a lint command

cdk/package.json

@@ -9,7 +9,9 @@
 		"test-update": "jest -u",
 		"synth": "cdk synth --path-metadata false --version-reporting false",
 		"diff": "cdk diff --path-metadata false --version-reporting false",
-		"format": "prettier --write \"{lib,bin}/**/*.ts\""
+		"format": "prettier --write \"{lib,bin}/**/*.ts\"",
+		"lint": "eslint src/** --ext .ts --no-error-on-unmatched-pattern --fix",
+		"lint:ci": "eslint src/** --ext .ts --no-error-on-unmatched-pattern"
 	},
 	"devDependencies": {
 		"@guardian/cdk": "59.3.0",
@@ -21,7 +23,7 @@
 		"source-map-support": "0.5.20"
 	},
 	"prettier": "@guardian/prettier",
-  "jest": {
+	"jest": {
 		"testMatch": [
 			"<rootDir>/lib/**/*.test.ts"
 		],

ingestion-lambda/package.json

@@ -6,7 +6,9 @@
 		"dev": "tsx watch localRun.ts",
 		"typecheck": "tsc -noEmit",
 		"build": "esbuild src/handler.ts --bundle --minify --outfile=dist/handler.js --external:@aws-sdk --external:aws-sdk --platform=node",
-		"test": "jest --detectOpenHandles --config ../jest.config.js --selectProjects ingestion-lambda"
+		"test": "jest --detectOpenHandles --config ../jest.config.js --selectProjects ingestion-lambda",
+		"lint": "eslint src/** --ext .ts --no-error-on-unmatched-pattern --fix",
+		"lint:ci": "eslint src/** --ext .ts --no-error-on-unmatched-pattern"
 	},
 	"dependencies": {
 		"@aws-sdk/client-s3": "3.637.0",

ingestion-lambda/src/handler.ts

@@ -22,6 +22,7 @@ const isCurlyQuoteFailure = (e: SyntaxError): boolean => {
 	return !!e.message.match(/Unexpected token '[“‘”’]'/);
 };
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're not currently validating this, though there's WIP for doing so
 const safeBodyParse = (body: string): any => {
 	try {
 		return JSON.parse(body);

ingestion-lambda/tsconfig.json

@@ -0,0 +1,3 @@
+{
+	"extends": "../tsconfig.json"
+}

package.json

@@ -12,7 +12,7 @@
 		"typecheck": "npm run typecheck --workspaces",
 		"format": "prettier --write --ignore-path .gitignore \"./**/*{.js,.ts,.json,.md,.yml}\"",
 		"build": "npm run build --workspaces --if-present",
-		"lint": "npm run lint --workspaces --if-present",
+		"lint": "npm run lint --workspaces",
 		"dev": "npm run dev --workspace=ingestion-lambda"
 	},
 	"repository": {