Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DNS config to cfn.yaml #201

Merged
merged 4 commits into from
Nov 23, 2023
Merged

add DNS config to cfn.yaml #201

merged 4 commits into from
Nov 23, 2023

Conversation

michaelbjacobson
Copy link
Contributor

@michaelbjacobson michaelbjacobson commented Nov 20, 2023 •
edited
Loading

This PR updates the AWS Cloudformation template to configure a custom url for the API.

@michaelbjacobson michaelbjacobson marked this pull request as ready for review November 20, 2023 11:39
rupertbates
rupertbates approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@rupertbates rupertbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbjacobson michaelbjacobson merged commit 017dd2f into main Nov 23, 2023
2 checks passed
@michaelbjacobson michaelbjacobson deleted the mj/configure-custom-url branch November 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupertbates rupertbates rupertbates approved these changes

@johnduffell johnduffell Awaiting requested review from johnduffell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbjacobson @rupertbates