make the 'graphic content blurring' explainer per-organisation #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
blurring/org-specific-explainer
branch
4 times, most recently
from
1894b89 to
6a15075
Compare
… on the existing config property `branding.staffPhotographerOrganisation`)
twrichards
force-pushed
the
blurring/org-specific-explainer
branch
from
6a15075 to
2868caa
Compare
AndyKilmory
approved these changes
Nov 22, 2023
dblatcher
approved these changes
Nov 22, 2023
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
and removed
Pending-on-cropper
Pending-on-media-api
Pending-on-image-loader
Pending-on-collections
Pending-on-usage
labels
|
Seen on auth, usage, image-loader, thrall, cropper, collections, media-api (merged by @twrichards 8 minutes and 50 seconds ago) Please check your changes! |
|
Seen on leases (merged by @twrichards 8 minutes and 56 seconds ago) Please check your changes! |
|
Seen on metadata-editor (merged by @twrichards 9 minutes and 1 second ago) Please check your changes! |
|
Seen on kahuna (merged by @twrichards 9 minutes and 52 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need different organisation specific explainers for the 'graphic content' blurring, since it's 'opt-out' (see #4187).
So based on the existing config property
branding.staffPhotographerOrganisation, it loads the relevant HTML file from the newpublic/js/common/blurringdirectory (e.g. staffPhotographerOrganisation isGNMso loadsGNM-explainer.htmlfrom that directory. This is rendered on top of the translucent overlay and the GNM implementation references thegraphic-image-blur-explainer__tooltipclass as before but allows for completely different styling/layout if needs be).From a GNM perspective this is a no-op (which can be verified in
TESTby deleting theSHOULD_BLUR_GRAPHIC_IMAGEScookie and reloading to reveal the explainer).