use 'persistent' cookie for 'graphic content' blurring (rather than session cookie) #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
graphic/default-to-on-with-tooltip
branch
2 times, most recently
from
f55dd98 to
5edbd35
Compare
twrichards
force-pushed
the
graphic/default-to-on-with-tooltip
branch
from
5edbd35 to
ce39716
Compare
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-leases
Seen-on-usage
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, metadata-editor, thrall, leases, cropper, collections, kahuna (merged by @twrichards 8 minutes and 58 seconds ago) Please check your changes! |
|
Seen on image-loader (merged by @twrichards 9 minutes and 6 seconds ago) Please check your changes! |
|
Seen on media-api (merged by @twrichards 9 minutes and 18 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that Angular's
$cookieslibrary defaults to session cookies (which I didn't spot, since the extension I was using to view the cookies whilst developing showed an expiry time).This PR adds an
expiresproperty to the cookie when setting it (set to today plus 399 days - the max expiry enforced by some browsers) and if the cookie exists it resets it every page load to effectively extend the expiry indefinitely (that also cleans-up/replaces the old 'session' cookies).