add uploadedInLastFiveMinutes to the imageCounts
#4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
image-counter-lambda/fix-searchResponseCount
branch
from
db133e2 to
4eff25f
Compare
Base automatically changed from
image-counter-lambda/fix-searchResponseCount
to
main
November 14, 2023 09:15
…is of a new alarm)
twrichards
force-pushed
the
image-counter-lambda/uploadedInLastFiveMinutes
branch
from
f7a0010 to
e3a5ec8
Compare
twrichards
deleted the
image-counter-lambda/uploadedInLastFiveMinutes
branch
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 9 minutes and 57 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the reaper is back in action (see #4145) we can no longer rely on the total count in ES for the alarms which hang-off the metrics produced by
image-counter-lambda(see https://github.com/guardian/editorial-tools-platform/blob/main/cloudformation/media-service-account/image-counter-lambda.yaml). These alarms exist for two reasons...This PR facilitates a new alarm to capture reason 1.
2 is much harder since we're reaping at a variable rate (effectively based on the ingestion rate from the moment 20 days prior).