fix reporting of searchResponseCount as it was always 10k
#4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipbarron
approved these changes
Nov 14, 2023
twrichards
force-pushed
the
image-counter-lambda/fix-searchResponseCount
branch
from
db133e2 to
4eff25f
Compare
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-collections
Seen-on-metadata-editor
Seen-on-thrall
and removed
Pending-on-metadata-editor
Pending-on-collections
Pending-on-thrall
labels
|
Seen on metadata-editor, collections, thrall (merged by @twrichards 8 minutes and 57 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-leases
Seen-on-usage
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-usage
labels
|
Seen on leases, cropper, usage, media-api (merged by @twrichards 9 minutes and 4 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-kahuna
and removed
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, kahuna (merged by @twrichards 9 minutes and 10 seconds ago) Please check your changes! |
|
Seen on image-loader (merged by @twrichards 9 minutes and 21 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed the
management/imageCountsendpoint ofmedia-apiwas always reporting 10k as thesearchResponseCountbecause it was lacking thetrackTotalHits=true(like searches via the UI get by default) and hence was capping out.Looks to have fixed things in
TEST...