Faster fades on load and progressive display of images #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waht are you thinking about this @AWare. I'm keen not to pick up any more work like this, but if this is close to shippable then it makes sense to realise the value by getting it over the line rather than parking it to rot. |
paperboyo
changed the title
twrichards
reviewed
Mar 2, 2021
Comment on lines
+10
to
+11
| const animationDuration = 200; // ms | ||
| const revealAfter = 1500; // ms |
There was a problem hiding this comment.
[nit] think this indentation is accidental
There was a problem hiding this comment.
yeah, the joys of prettier
twrichards
approved these changes
Mar 2, 2021
Currently the image fade in on load applies an element style using the angular digest loop. As this style stuff is done on the element directly there's no state here for angular to track. I've reorganised things to: - make the reveal happen before we do any $q promisey stuff, so no more waiting on the digest loop - set a timeout (which ironically will fire in the digest loop) so that after a while we just show the image some changes
sihil
force-pushed
the
aw-reveal-digest-loop
branch
from
a154a2a to
b128594
Compare
prout-bot
added
Pending-on-auth
Pending-on-collections
Pending-on-cropper
Pending-on-image-loader
Pending-on-image-loader-projection
Pending-on-kahuna
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-usage
and removed
Pending-on-auth
Pending-on-collections
Pending-on-cropper
Pending-on-image-loader
labels
prout-bot
added
Seen-on-auth
Seen-on-collections
Seen-on-cropper
Seen-on-image-loader
Seen-on-image-loader-projection
Seen-on-kahuna
Seen-on-leases
Seen-on-media-api
Seen-on-metadata-editor
Seen-on-usage
and removed
Pending-on-image-loader-projection
Pending-on-kahuna
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-usage
labels
|
Seen on auth, usage, cropper, collections, media-api, kahuna, image-loader, image-loader-projection, metadata-editor, leases (created by @AWare and merged by @paperboyo 15 minutes ago) Please check your changes! |
ochiengolanga
pushed a commit
to bbc/grid
that referenced
this pull request
Mar 4, 2021
Faster fades on load and progressive display of images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We are using a very nice fading of thumbnails and main preview. Sadly, it depends on them being loaded in full. We have imgOps configured to provide progressive JPEGs.
This PR:
Currently, the image fade in on load applies an element style using the
angular digest loop. As this style stuff is done on the element directly
there's no state here for angular to track. I've reorganised things to:
How can success be measured?
I think this would work better with #3166 from @paperboyo than just dropping the fade. The app should feel more snappy.
Screenshots
(bottom: current situation)
Viewer:
Browser (played at 25% speed for effect):
Who should look at this?
@guardian/digital-cms
Tested?