Add an exponential backoff to the apiPoll function. #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
reviewed
Dec 10, 2019
Co-Authored-By: Akash Askoolum <[email protected]>
akash1810
approved these changes
Dec 11, 2019
|
Seen on auth, usage, cropper, collections, media-api, kahuna, image-loader, metadata-editor, leases (merged by @AWare 8 minutes and 39 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
While this was probably sensible, testing with @paperboyo didn't show any improvement.
This PR adds an exponential backoff with jitter to the
apiPollfunction. This increases the delay to 2^(attempt) plus a little random noise.How can success be measured?
Testing this against an upload of 30 images reduced the http request total from ~800 to ~500
Slightly more performant batch jobs.
Screenshots (if applicable)
Who should look at this?
@akash1810 @mbarton @paperboyo
Tested?