Passcodes | Use new sign in ux for passcodes behind flag #3025
+292
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
added
the
passwordless
coldlink
requested review from
guardian-ci
and removed request for
guardian-ci
coldlink
force-pushed
the
mm/passcode-signin-ux-changes
branch
from
9d336a4 to
64e74a2
Compare
AshCorr
previously approved these changes
Jan 13, 2025
coldlink
force-pushed
the
mm/passcode-signin-ux-changes
branch
from
68c378a to
9e830c4
Compare
coldlink
force-pushed
the
mm/passcode-signin-ux-changes
branch
from
9e830c4 to
4fbf374
Compare
AshCorr
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
In #2942 we implemented sign in using a one time passcode behind a feature flag (query parameter)
?usePasscodeSignIn=true.The UX in that example wasn't particularly ideal, where we used a toggle to allow the reader to switch between sign in via passcodes or sign in via passwords.
In this PR we change the UX to remove the toggle, and instead when using the feature flag, we make passcodes the default option.
In this scenario, the reader has to just enter their email address and click "Continue with email". We then send the user a passcode, and show the passcode input page as before. However we've added an additional button here which allows the reader to "Sign in with password instead".
This button will take them to a sign in page with the password input, where they can use a password to sign in.
Screen.Recording.2025-01-14.at.10.20.25.mov
Screen.Recording.2025-01-14.at.10.21.16.mov
This PR also sets up an AB test for passcodes, which rather than used for AB testing, we use it to release passcodes to 10% of the audience so we can test out the flow and look for any issues that may occur.
Tested