feat: Add more information to errors if we think cookies are missing #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
force-pushed
the
ash/cookie-errors
branch
from
8937c6f to
22f0e45
Compare
coldlink
approved these changes
Nov 26, 2024
AshCorr
requested review from
guardian-ci
and removed request for
guardian-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
If a user has cookies disabled the most likely error they'll encounter is a CSRF error as we expect this cookie to exist on almost every page visit and we check it before almost everything else.
I spent some time trying to add safety checks to everywhere we check for cookies, but that became a mess of trying to propagate the correct errors to the correct places and figuring out where we expect cookies to sometimes not exist. I think this approach should catch the vast majority, if not all, of users that don't have cookies enabled.
How to test
Turn off cookies and attempt a login, you should be redirected to a CSRF error page with the updated error message.