Add GET /signout/all endpoint
#2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
changed the title
GET /signout/all endpoint to sign out users on a…GET /signout/all endpoint
coldlink
force-pushed
the
mm/global-signout
branch
from
3b73ddb to
dabe728
Compare
coldlink
requested review from
guardian-ci
and removed request for
guardian-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2462 we updated sign out so that we only sign out on the current device/browser, instead of AL browsers/devices/apps when the user clicks "Sign Out" on the web, or navigates to the sign out link directly.
This provides better user experience where if they are logged into multiple devices or apps they will no longer get logged out of those devices when they sign out on the web on another device.
However a case by user help was made that they used the old way of signing out in order to reset a user's session.
So this PR adds a new endpoint built specifically for this use case:
GET /signout/allwhich works in the same way thatGET /signoutdid pre #2462 by revert cherrypicking some of the code that was removed.This way most users who sign out will get the expected behaviour of only signing out on the current device/browser when they click on a link to sign out rather than all devices, and if required user help can send users to the new endpoint in order to sign users out from all devices/browsers if required!