Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta Identity Engine | Switch from sid cookie to idx cookie in tests and documentation #2450

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

coldlink
Copy link
Member

What does this change?

As it says in the title, this PR switches from the sid cookie to the idx cookie in tests and documentation, in some cases we still keep both where the sid and idx cookie might be set together, e.g. on Sign Out tests, and tests where we need to check if certain cookies exist or not.

@coldlink coldlink requested a review from a team as a code owner October 20, 2023 08:08
Copy link
Contributor

@raphaelkabo raphaelkabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/sid/idx/g 👍

@coldlink coldlink requested review from guardian-ci and removed request for guardian-ci October 23, 2023 11:48
@coldlink coldlink enabled auto-merge October 23, 2023 11:49
@coldlink coldlink merged commit bb69fe7 into main Oct 23, 2023
25 checks passed
@coldlink coldlink deleted the mm/sid-to-idx branch October 23, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants