Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prod SNSTopic #1533

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add prod SNSTopic #1533

merged 1 commit into from
Nov 17, 2023

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Nov 17, 2023

Co-authored-by: @twrichards
Co-authored-by: @silvacb

What's changed?

Now that this platform PR is in prod, creating an SNS Topic, as a follow-up to this previous PR which enabled the fronts tool to publish to an sns topic, this PR specifies the prod SNS topic for the tool to point at.

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Georges-GNM Georges-GNM requested a review from a team as a code owner November 17, 2023 11:49
Copy link
Contributor

@twrichards twrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We obviously plan to move these sorts of config values into per env config files not in VCS.

@Georges-GNM Georges-GNM merged commit 857b768 into main Nov 17, 2023
1 check passed
@Georges-GNM Georges-GNM deleted the gl-tr-sb/add-prod-snstopic branch November 17, 2023 11:59
@prout-bot
Copy link

Seen on PROD (merged by @Georges-GNM 10 minutes and 48 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants