Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jspm-github because https://github.com/jspm/github/issues/129 #1301

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

AWare
Copy link
Contributor

@AWare AWare commented Feb 12, 2021

What's changed?

jspm-github has a change because github change their api

jspm/github#129 (comment)

I've added an explicit dependency rather than just regenerating the package-lock

Implementation notes

Checklist

General

  • na 🤖 Relevant tests added
  • na ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • na 📷 Screenshots / GIFs of relevant UI changes included

@AWare AWare merged commit 6fb0036 into main Feb 12, 2021
@AWare AWare deleted the aw-upgrade-jspm-github branch February 12, 2021 16:50
@prout-bot
Copy link

Seen on PROD (merged by @AWare 8 minutes and 41 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants