Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anagram helper control it's own visability #1884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Anagram helper control it's own visability #1884

wants to merge 1 commit into from
+21 −10

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Jan 7, 2025 •
edited
Loading

What are you changing?

  • Adding the position:relative to the crossword wrapper div and the position:absolute to the anagram helper.
  • Make the Anagram helper only render if the state is showAnagramHelper = true

Why?

  • This means we can make sure that the anagram helper is relative to the whole space given to the crossword.

@oliverabrahams oliverabrahams requested a review from a team as a code owner January 7, 2025 15:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 829c40a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 7, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliverabrahams