Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise crossword event handler names #1867

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Standardise crossword event handler names #1867

merged 1 commit into from
Dec 20, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Dec 20, 2024

What are you changing?

  • standardises event handler names on handle_

Why?

  • we have a mixture of onEvent and handleEvent naming for event handlers and it looks weird

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Dec 20, 2024
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Dec 20, 2024
@sndrs sndrs self-assigned this Dec 20, 2024
@sndrs sndrs requested a review from a team as a code owner December 20, 2024 12:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: d8c7058

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs enabled auto-merge December 20, 2024 12:20
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 20, 2024
@sndrs sndrs merged commit 1541b0a into main Dec 20, 2024
25 checks passed
@sndrs sndrs deleted the sndrs/xwd/handler-names branch December 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees

@sndrs sndrs

Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @oliverabrahams