Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type for current cell context a Cell type #1864

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Make type for current cell context a Cell type #1864

merged 1 commit into from
Dec 19, 2024

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Dec 19, 2024 •
edited
Loading

What are you changing?

  • Updates the type for current cell to store the full cell data rather than just the coords

Why?

  • Making this the type cell feels more correct and the other cell data (group, solution) is very helpful for a11y descriptions (the aria-label on the input)

@oliverabrahams oliverabrahams requested a review from a team as a code owner December 19, 2024 13:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 4dcac25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 19, 2024
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Dec 19, 2024
@oliverabrahams oliverabrahams enabled auto-merge (squash) December 19, 2024 15:57
@oliverabrahams oliverabrahams merged commit 7c7b866 into main Dec 19, 2024
23 checks passed
@oliverabrahams oliverabrahams deleted the oa/cell-context-Cell-type branch December 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverabrahams @sndrs