Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve controls a11y #1862

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Improve controls a11y #1862

merged 2 commits into from
Dec 19, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Dec 19, 2024

What are you changing?

  • remove un-rendered controls from focus management (so we don't try to set focus on controls that aren't there)
  • add comments describing the appraoch

Why?

  • hopefully it's better

@sndrs sndrs requested a review from a team as a code owner December 19, 2024 11:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 1a18484

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs self-assigned this Dec 19, 2024
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added this to the Decommission Frontend Rendering milestone Dec 19, 2024
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Dec 19, 2024
@sndrs sndrs enabled auto-merge December 19, 2024 11:30
@sndrs sndrs merged commit b1333dc into main Dec 19, 2024
23 checks passed
@sndrs sndrs deleted the sndrs/xwd/a11y/improve-controls branch December 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees

@sndrs sndrs

Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @oliverabrahams