Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Clues keyboard-navigable #1860

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Make Clues keyboard-navigable #1860

merged 7 commits into from
Dec 18, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Dec 18, 2024

What are you changing?

  • makes the lists of clues navigable by tabbing
  • makes the individual clues navigable using the arrow keys
  • refactors some state names (which i hope make more sense)
    • related → connected
    • active → selected
  • prevents the Grid from trapping the tab key

@sndrs sndrs requested a review from a team as a code owner December 18, 2024 17:15
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d2d65bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs changed the title related → connected and active → selected Make Clues keyboard-navigable Dec 18, 2024
@sndrs sndrs self-assigned this Dec 18, 2024
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Dec 18, 2024
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Dec 18, 2024
@sndrs sndrs linked an issue Dec 18, 2024 that may be closed by this pull request
Make Clues keyboard-navigable guardian/dotcom-rendering#13029
Closed
oliverabrahams
oliverabrahams approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sndrs sndrs force-pushed the sndrs/xwd/a11y/clues branch from 3dcf8d8 to d2d65bb Compare December 18, 2024 18:11
@sndrs sndrs enabled auto-merge December 18, 2024 18:11
@sndrs sndrs merged commit 2d08fb7 into main Dec 18, 2024
21 checks passed
@sndrs sndrs deleted the sndrs/xwd/a11y/clues branch December 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees

@sndrs sndrs

Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
WebX Team
Archived in project
Milestone
Decommission Frontend Rendering
Development

Successfully merging this pull request may close these issues.

Make Clues keyboard-navigable
2 participants
@sndrs @oliverabrahams