Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop loading the cmp if user is on info page #1847

Merged
merged 14 commits into from
Jan 13, 2025
Merged

Stop loading the cmp if user is on info page #1847

merged 14 commits into from
Jan 13, 2025
+33 −0

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented Dec 10, 2024 •
edited
Loading

What are you changing?

  • Preventing the CMP banner from loading on informational pages.
  • Configuring the excludePage as a targeting parameter for Sourcepoint.

Why?

  • The CMP banner should not show on info pages.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1b849c2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels Dec 10, 2024
@akinsola-guardian akinsola-guardian added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@akinsola-guardian akinsola-guardian changed the title White list info section Stop loading the cmp if user is on info page Dec 19, 2024
@akinsola-guardian akinsola-guardian removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Dec 19, 2024
@akinsola-guardian akinsola-guardian added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Note

The following canaries were published to NPM:

🐥

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Note

The following canaries were published to NPM:

🐥

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Note

The following canaries were published to NPM:

🐥

@akinsola-guardian akinsola-guardian marked this pull request as ready for review January 9, 2025 12:43
@akinsola-guardian akinsola-guardian requested review from a team as code owners January 9, 2025 12:43
@akinsola-guardian akinsola-guardian requested review from a team as code owners January 9, 2025 12:43
@akinsola-guardian akinsola-guardian removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Jan 9, 2025
@akinsola-guardian akinsola-guardian force-pushed the al-white-list-info-section branch from 6a2160d to 6caf64e Compare January 9, 2025 15:45
@akinsola-guardian akinsola-guardian added the run_chromatic Runs chromatic when label is applied label Jan 9, 2025
oliverabrahams
oliverabrahams reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments to make the changes clearer for consumers

.changeset/wise-dancers-travel.md Outdated Show resolved Hide resolved
.changeset/wise-dancers-travel.md Outdated Show resolved Hide resolved
oliverabrahams
oliverabrahams approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@akinsola-guardian akinsola-guardian merged commit 34042f6 into main Jan 13, 2025
21 checks passed
@akinsola-guardian akinsola-guardian deleted the al-white-list-info-section branch January 13, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

@AshCorr AshCorr AshCorr approved these changes

Assignees
No one assigned
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akinsola-guardian @AshCorr @oliverabrahams