Add theme prop to Icons
#1155
Add theme prop to Icons
#1155
Conversation
🦋 Changeset detectedLatest commit: 741a15b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
oliverabrahams
changed the base branch from
main
to
release/source-react-components-themeing
Yes, I think that makes sense. What do you think? |
Yes, I think that enabling polychromatic icons to be styled is going to be a much larger endeavour that is best tackled only if consumers demand it. |
| @@ -327,19 +331,6 @@ MediumIconsBrandTheme.parameters = { | |||
| default: 'brandBackground.primary', | |||
| }, | |||
| }; | |||
| MediumIconsBrandTheme.decorators = [ | |||
There was a problem hiding this comment.
Glad to see these style overrides removed and replaced with a supported method so we're not encouraging people to do the wrong thing 🙈
oliverabrahams
merged commit 094d0a0
into
release/source-react-components-themeing
What are you changing?
Why?