Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity-auth | OAuth token verifier #1037

Closed
wants to merge 6 commits into from
Closed

Conversation

raphaelkabo
Copy link

@raphaelkabo raphaelkabo commented Dec 19, 2023

What are you changing?

This PR adds token verification mechanisms to the identity-auth library, which we want to be able to centralise and simplify authorization processes in the new Identity setup, which uses OAuth tokens. In particular, we add methods to verify OAuth access and ID tokens both locally and (for access tokens), serverside.

Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: 6e18737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 19, 2023
@raphaelkabo raphaelkabo force-pushed the rk-mm/token-validation branch from 5f9372e to 959aab7 Compare December 19, 2023 14:45
@coldlink coldlink force-pushed the rk-mm/token-validation branch from c2dcfcc to aa6fbba Compare January 10, 2024 09:03
@sndrs
Copy link
Member

sndrs commented Feb 7, 2024

hi @raphaelkabo, is this still needed?

@raphaelkabo
Copy link
Author

@sndrs Yep, we're coming back to keep working on this this week!

Raphael Kabo and others added 2 commits February 13, 2024 10:37
@raphaelkabo raphaelkabo force-pushed the rk-mm/token-validation branch from aa6fbba to 30a2c8a Compare February 13, 2024 10:37
@raphaelkabo
Copy link
Author

We're going to close this PR, but keep the branch in source control, because we'll return to it later this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants