Skip to content

Commit

Permalink
Remove QuoteIcon (#1730)
Browse files Browse the repository at this point in the history
## What are you changing?

- Remove the QuoteIcon component, related tests and stories, and the
HeadlineSize type
- Extra bit: Fix the Logo README title, which was previously mistakenly
"QuoteIcon"

## Why?

- QuoteIcon and HeadlineSize are not used anywhere. DCR uses [its own
implementation](https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/QuoteIcon.tsx)
- We are moving format-related types into DCR
(guardian/dotcom-rendering#12461). Removing this component removes one
usage of format outside of DCR
  • Loading branch information
SiAdcock authored Oct 10, 2024
2 parents 02018b3 + 4b0acdf commit 097cb9d
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 329 deletions.
5 changes: 5 additions & 0 deletions .changeset/perfect-vans-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@guardian/source-development-kitchen': major
---

Remove `QuoteIcon` component and `HeadlineSize` type
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ export type {
LogoProps,
NumericInput,
NumericInputProps,
HeadlineSize,
QuoteIconProps,
StarRatingProps,
ToggleSwitchProps,
ToggleSwitchAppsProps,
Expand All @@ -35,7 +33,6 @@ it('Should have exactly these exports', () => {
'Lines',
'Logo',
'NumericInput',
'QuoteIcon',
'SquigglyLines',
'StarRating',
'StraightLines',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ export type { LineCount, LinesProps } from './lines/Lines';
export { Logo } from './logo/Logo';
export type { LogoProps } from './logo/Logo';

export { QuoteIcon } from './quote-icon/QuoteIcon';
export type { HeadlineSize, QuoteIconProps } from './quote-icon/QuoteIcon';

export { StarRating } from './star-rating/StarRating';
export type { StarRatingProps } from './star-rating/StarRating';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# QuoteIcon
# Logo

The Guardian logo appears in the header on most editorial pages

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 097cb9d

Please sign in to comment.