-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## What are you changing? - Remove the QuoteIcon component, related tests and stories, and the HeadlineSize type - Extra bit: Fix the Logo README title, which was previously mistakenly "QuoteIcon" ## Why? - QuoteIcon and HeadlineSize are not used anywhere. DCR uses [its own implementation](https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/QuoteIcon.tsx) - We are moving format-related types into DCR (guardian/dotcom-rendering#12461). Removing this component removes one usage of format outside of DCR
- Loading branch information
Showing
7 changed files
with
6 additions
and
329 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@guardian/source-development-kitchen': major | ||
--- | ||
|
||
Remove `QuoteIcon` component and `HeadlineSize` type |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
libs/@guardian/source-development-kitchen/src/react-components/logo/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# QuoteIcon | ||
# Logo | ||
|
||
The Guardian logo appears in the header on most editorial pages | ||
|
||
|
153 changes: 0 additions & 153 deletions
153
...guardian/source-development-kitchen/src/react-components/quote-icon/QuoteIcon.stories.tsx
This file was deleted.
Oops, something went wrong.
144 changes: 0 additions & 144 deletions
144
libs/@guardian/source-development-kitchen/src/react-components/quote-icon/QuoteIcon.tsx
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
.../@guardian/source-development-kitchen/src/react-components/quote-icon/README.md
This file was deleted.
Oops, something went wrong.