Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc explaining the codebase structure #1743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

arelra
Copy link
Member

@arelra arelra commented Jan 15, 2025

What does this change?

A document that explains the current codebase structure

Slight assumption that #1734 will be merged for the libs directory but we can update if not.

Why?

Helps new joiners to the team.

@dskamiotis @deedeeh @cemms1

@arelra arelra requested a review from a team as a code owner January 15, 2025 10:51
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 2f188a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4268ms to load.
For consentless, top-above-nav took on average 3096ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant