Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import prebid as a module #1737

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Import prebid as a module #1737

wants to merge 2 commits into from

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Jan 10, 2025

What does this change?

Import the prebid module rather than the built bundle.

Why?

Allows us to use our own bundling tools and browser targets.
Also allows webpack to chunk more effectively (this might not necessarily be good yet! But interesting)

Comparison of bundle analyzer results:
before:
Screenshot 2025-01-10 at 15 42 09

after:
Screenshot 2025-01-10 at 15 40 58

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: f4f8fc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant