Remove Sonobi SSP from Prebid Configuration #1732
Merged
+9
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6fadd73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
cemms1
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Looks great @dskamiotis ✨
Just wondering if we need to remove the test 'should only include multiple bidders being tested, even when their switches are off' since we could test this with a different bidder?
|
I think the title should be SSP? 😉 |
dskamiotis
changed the title
dskamiotis
force-pushed
the
ds/remove-sonobi-ssp
branch
from
eda3b86 to
6fadd73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR removes the Sonobi SSR (Server-Side Rendering) integration from the Prebid configuration. The following changes have been made to achieve this:
Removed Sonobi Bidder Configuration:
Deleted all references to the Sonobi bidder from the Prebid configuration files.
Removed Sonobi-specific parameters and targeting logic.
Updated Bidder Imports:
Removed Sonobi-related imports from the relevant modules.
Cleaned Up Bidder Code:
Ensured that any Sonobi-specific code, including bid requests and response handling, has been removed.
Updated Documentation:
Updated any relevant documentation to reflect the removal of the Sonobi bidder.## Why?
Sonobi has been determined to be not be worthwhile supporting. Let’s remove the SSP and all associated code.
Why?
Sonobi has been determined to be not be worthwhile supporting.
The Sonobi bidder was previously configured to participate in the header bidding process via Prebid.
This PR ensures that Sonobi is no longer included in the bid requests or responses.
The removal of Sonobi simplifies the Prebid configuration and reduces the overall complexity of the header bidding setup.
Testing: