-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch over to riff-raff deploys #1720
base: main
Are you sure you want to change the base?
Conversation
|
Ad load time test resultsFor Test conditions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic documentation 👏
I think possibly in an ideal world, the PRout part would be done in a separate PR. I only say that as it's not always the most straightforward thing to set up and you wouldn't want to revert the other changes if purely the PRout part wasn't working as expected?
I'm also curious why we are going with Cloudformation directly rather than using CDK? Here's an example of a parameter being saved as part of a CDK stack https://github.com/guardian/dotcom-rendering/blob/a6ca5dd61262ef3d11bb27ae2f20dc3d654ded65/dotcom-rendering/cdk/lib/renderingStack.ts#L286-L291
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're using Cloudformation rather than CDK here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's to avoid the overhead of maintaining a bunch of CDK and it's dependencies, as it's just a couple of parameters in ssm, this seemed nicer, if it were any more complicated CDK would definitely be the better shout!
{ | ||
"checkpoints": { | ||
"PROD": { | ||
"url": "https://assets-code.guim.co.uk/commercial/prout", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this points to code btw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙈
Co-authored-by: Charlotte Emms <[email protected]>
What does this change?
The riff-raff deploys introduced in #1693 are working great, we are switching to it for 100%.
This PR:
webpack
Why?
Developer Experience