remove a9 block bidder add for fronts #1692
Conversation
🦋 Changeset detectedLatest commit: bdc534a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dskamiotis
force-pushed
the
ds/remove-a9-blockbidder-add-for-fronts
branch
from
b0389b1 to
db09f35
Compare
Ad load time test resultsFor Test conditions:
|
src/lib/header-bidding/a9/a9.ts
Outdated
| const isNetworkFront = | ||
| section === 'uk' || section === 'us' || section === 'au'; | ||
|
|
||
| const filteredAdUnits = adUnits.filter((adUnit) => { |
There was a problem hiding this comment.
We still want a9 to work in the other slots, just not gumgum afaik.
There was a problem hiding this comment.
Yep, Jake's right. I see the issue here, we want:
- A9 to run everywhere
- But prevent GumGum running in certain slots, when it serves on section fronts
As I type this is realise it's quite the messy rule want to chat it through @dskamiotis?
There was a problem hiding this comment.
thanks @Amouzle I have an idea/solution, but will chat it through to confirm if thats ok
There was a problem hiding this comment.
This still prevents a9 from running for all the other slots on fronts, it's also preventing all bidders not just GumGum?
There was a problem hiding this comment.
@Jakeii I thought we only wanted specif slots for the network and section fronts?
On Network Front === inline1 (as we would like it further down the page)
On Section Fronts === top-above-nav
and all other slots for non fronts?
There was a problem hiding this comment.
We want only GumGum to be blocked in the other slots, the code you've got prevents any A9 bidder not just GumGum.
As @Amouzle said above, we still want A9 working everywhere.
dskamiotis
force-pushed
the
ds/remove-a9-blockbidder-add-for-fronts
branch
2 times, most recently
from
8ee4ce7 to
476ea15
Compare
src/lib/header-bidding/a9/a9.ts
Outdated
| return adUnit.slotID === 'dfp-ad--inline1--mobile'; | ||
| } | ||
| if (isSectionFront) { | ||
| return adUnit.slotID === 'dfp-ad--top-above-nav'; |
There was a problem hiding this comment.
Is this meant to be 'dfp-ad--top-above-nav--mobile'?
dskamiotis
force-pushed
the
ds/remove-a9-blockbidder-add-for-fronts
branch
from
476ea15 to
8c7e2bc
Compare
…e interfacing with APS api
What does this change?
This PR reintroduces the ability for GumGum (interscroller ads) to serve on Fronts after being previously blocked.
Changes to A9 module:
dfp-ad--inline1--mobile.dfp-ad--top-above-nav.2. Bidder Blocking:
Network front: Blocks GumGum for dfp-ad--inline1--mobile.
Section front: Blocks GumGum for dfp-ad--top-above-nav.
3. Ad Unit Updates:
Why?
GumGum interscrollers were blocked in a previous ticket (linked below) but generated significant revenue before the block. Commercial has approved reintroducing them under these controlled conditions to balance user experience and revenue.
Notes
inline1andtop-above-navad slots were chosen based on their positions to optimize both user engagement and ad performance.Related PR: Add blocked bidder within Amazon A9 for SSP GumGum when on Fronts
Screenshots