Skip to content

Commit

Permalink
Remove deeply read right column test (#1460)
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielCliftonGuardian authored Jul 9, 2024
1 parent 5151be8 commit 6d6e9b9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 45 deletions.
5 changes: 5 additions & 0 deletions .changeset/angry-tools-rhyme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@guardian/commercial': minor
---

Remove deeply read right column test
2 changes: 0 additions & 2 deletions src/experiments/ab-tests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { ABTest } from '@guardian/ab-core';
import { deeplyReadRightColumn } from './tests/deeply-read-right-column';
import { mpuWhenNoEpic } from './tests/mpu-when-no-epic';

/**
Expand All @@ -10,5 +9,4 @@ import { mpuWhenNoEpic } from './tests/mpu-when-no-epic';
export const concurrentTests: readonly ABTest[] = [
// one test per line
mpuWhenNoEpic,
deeplyReadRightColumn,
];
35 changes: 0 additions & 35 deletions src/experiments/tests/deeply-read-right-column.ts

This file was deleted.

9 changes: 1 addition & 8 deletions src/insert/spacefinder/article.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import {
getCurrentBreakpoint,
getCurrentTweakpoint,
} from 'lib/detect/detect-breakpoint';
import { isInVariantSynchronous } from '../../experiments/ab';
import { deeplyReadRightColumn } from '../../experiments/tests/deeply-read-right-column';
import fastdom from '../../utils/fastdom-promise';
import { computeStickyHeights, insertHeightStyles } from '../sticky-inlines';
import { initCarrot } from './carrot-traffic-driver';
Expand All @@ -43,11 +41,6 @@ const hasImages = !!window.guardian.config.page.lightboxImages?.images.length;
const hasShowcaseMainElement =
window.guardian.config.page.hasShowcaseMainElement;

const isInDeeplyReadMostViewedVariant = isInVariantSynchronous(
deeplyReadRightColumn,
'deeply-read-and-most-viewed',
);

const minDistanceBetweenRightRailAds = 500;
const minDistanceBetweenInlineAds = isInHighValueSection ? 500 : 750;

Expand Down Expand Up @@ -225,7 +218,7 @@ const addDesktopRightRailAds = (fillSlot: FillAdSlot): Promise<boolean> => {
* In special cases, inline2 can overlap the "Most viewed" island, so
* we need to make an adjustment to move the inline2 further down the page
*/
if (isInDeeplyReadMostViewedVariant || isPaidContent) {
if (isPaidContent) {
minAbove += MOST_VIEWED_HEIGHT;
}

Expand Down

0 comments on commit 6d6e9b9

Please sign in to comment.