Skip to content

Commit

Permalink
Merge cab862a into 2caca1e
Browse files Browse the repository at this point in the history
  • Loading branch information
deedeeh authored May 2, 2024
2 parents 2caca1e + cab862a commit 5111c81
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/two-dolls-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@guardian/commercial': minor
---

Move im below inline1 to reduce revenue impact when the im won't serve ads"
4 changes: 2 additions & 2 deletions src/insert/spacefinder/article.ts
Original file line number Diff line number Diff line change
Expand Up @@ -498,14 +498,14 @@ const init = async (fillAdSlot: FillAdSlot): Promise<boolean> => {
return Promise.resolve(false);
}

await addInlineAds(fillAdSlot);

const im = window.guardian.config.page.hasInlineMerchandise
? attemptToAddInlineMerchAd(fillAdSlot)
: Promise.resolve(false);
const inlineMerchAdded = await im;
if (inlineMerchAdded) await waitForAdvert('dfp-ad--im');

await addInlineAds(fillAdSlot);

await initCarrot();

return im;
Expand Down

0 comments on commit 5111c81

Please sign in to comment.