refactor and use @guardian/ab-core in commrcial (#1457)

* initial refactor of ab tests and related code * remove ab-ophan modue * fix jest test fail for setTargetting * remove redundant modules * add changeset * Update src/experiments/ab.ts Co-authored-by: Jake <[email protected]> * update pnpm-lock * update pnpm lock * update logs to commercial --------- Co-authored-by: Jake <[email protected]>
guardian · Jul 19, 2024 · 25031be · 25031be
1 parent ba4b7d9
commit 25031be
Show file tree

Hide file tree

Showing 20 changed files with 151 additions and 764 deletions.
diff --git a/.changeset/rotten-vans-dance.md b/.changeset/rotten-vans-dance.md
@@ -0,0 +1,5 @@
+---
+'@guardian/commercial': patch
+---
+
+replaces current ab test library with @guardian/ab-core
diff --git a/jest.setupTestFrameworkScriptFile.js b/jest.setupTestFrameworkScriptFile.js
@@ -25,6 +25,7 @@ window.guardian = {
 	},
 	ophan: {
 		pageViewId: 'dummy_pvid_123456790',
+		record: jest.fn(),
 	},
 	css: {},
 	adBlockers: {

diff --git a/src/experiments/ab-core.ts b/src/experiments/ab-core.ts
diff --git a/src/experiments/ab-local-storage.ts b/src/experiments/ab-local-storage.ts
diff --git a/src/experiments/ab-ophan.ts b/src/experiments/ab-ophan.ts
diff --git a/src/experiments/ab-tests.ts b/src/experiments/ab-tests.ts
@@ -6,7 +6,7 @@ import { mpuWhenNoEpic } from './tests/mpu-when-no-epic';
  * the commercial code. Any test here also needs to be in both DCR and Frontend,
  * but any tests in DCR and Frontend do not need to necessarily be added here.
  */
-export const concurrentTests: readonly ABTest[] = [
+export const concurrentTests: ABTest[] = [
 	// one test per line
 	mpuWhenNoEpic,
 ];
diff --git a/src/experiments/ab-url.ts b/src/experiments/ab-url.ts
@@ -1,5 +1,4 @@
-import type { ABTest, Participations, Variant } from '@guardian/ab-core';
-import { testAndParticipationsToVariant } from './ab-utils';
+import type { Participations } from '@guardian/ab-core';
 
 export const getForcedParticipationsFromUrl = (): Participations => {
 	if (window.location.hash.startsWith('#ab')) {
@@ -21,13 +20,3 @@ export const getForcedParticipationsFromUrl = (): Participations => {
 
 	return {};
 };
-
-// If the given test has a variant which is forced by the URL, return it
-export const getVariantFromUrl = (test: ABTest): Variant | null | undefined =>
-	testAndParticipationsToVariant(test, getForcedParticipationsFromUrl());
-
-// Useful if you want to force a test even when it normally wouldn't run
-// (for example, to display a specific epic variant to verify it renders
-// okay).
-export const getIgnoreCanRunFromUrl = (): boolean =>
-	window.location.hash.includes('ignoreCanRun=true');
diff --git a/src/experiments/ab-utils.ts b/src/experiments/ab-utils.ts