Minor tweaks #23
Merged
Minor tweaks #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are often lots of PRs opened in the last day, perhaps we can use a terser message for those.
AshCorr
approved these changes
Jan 12, 2024
|
We ran through testing this locally before merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Just a couple of minor tweaks, while I get to grips with Rust and this repo.
How to test
I don't have a Github Token or Webhook URL to hand, so I have not run this locally. If someone would like to pair with me on getting hold of those secrets for local testing I'd love to do that, otherwise with carefuly approval perhaps this can go out and be checked in-place.
How can we measure success?
The codebase is slightly simplified, and the messages a little easider to read.
Have we considered potential risks?
Untested, there's a risk I've mucked something up (although it compiles fine).