refactor(src): remove unnecessary code

- Remove unused import - Remove unused method
guanguans · Aug 11, 2023 · af8c526 · af8c526
1 parent cd96d45
commit af8c526
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 11 deletions.
diff --git a/src/ExceptionNotifyManager.php b/src/ExceptionNotifyManager.php
@@ -31,7 +31,6 @@
 use Guanguans\LaravelExceptionNotify\Jobs\ReportExceptionJob;
 use Guanguans\Notify\Factory;
 use Illuminate\Cache\RateLimiter;
-use Illuminate\Contracts\Container\BindingResolutionException;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Manager;
 use Illuminate\Support\Str;
@@ -108,9 +107,6 @@ public function getDefaultDriver()
         return Arr::first((array) config('exception-notify.defaults'));
     }
 
-    /**
-     * @throws BindingResolutionException
-     */
     protected function shouldntReport(\Throwable $throwable): bool
     {
         if (! config('exception-notify.enabled')) {

diff --git a/src/Jobs/ReportExceptionJob.php b/src/Jobs/ReportExceptionJob.php
@@ -43,9 +43,6 @@ public function __construct(array $reports)
         }
     }
 
-    /**
-     * @noinspection BadExceptionsProcessingInspection
-     */
     public function handle(): void
     {
         foreach ($this->reports as $name => $report) {

diff --git a/tests/Macros/RequestMacroTest.php b/tests/Macros/RequestMacroTest.php
@@ -1,7 +1,5 @@
 <?php
 
-/** @noinspection NullPointerExceptionInspection */
-
 declare(strict_types=1);
 
 /**
@@ -12,8 +10,10 @@
  * This source file is subject to the MIT license that is bundled.
  */
 
+use Illuminate\Http\Request;
+
 it('can get headers', function (): void {
-    expect(request())
+    expect($this->app->make(Request::class))
         ->headers()->toBeArray()
         ->headers('user-agent')->toBeString();
 })->group(__DIR__, __FILE__);
diff --git a/tests/Pipes/PipeTest.php b/tests/Pipes/PipeTest.php
@@ -35,6 +35,9 @@
         )
         ->through(FixPrettyJsonPipe::class)
         ->then(
+            /**
+             * @throws JsonException
+             */
             static fn (Collection $collectors): Stringable => str(to_pretty_json($collectors->jsonSerialize()))
                 ->substr(-256)
         );

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -53,7 +53,7 @@ protected function tearDown(): void
     {
         parent::tearDown();
         if ($container = \Mockery::getContainer()) {
-            $this->addToAssertionCount($container->Mockery_getExpectationCount());
+            $this->addToAssertionCount($container->mockery_getExpectationCount());
         }
 
         \Mockery::close();