Refactor(src): Improve exception reporting

- Use bindTo() to bind reportUsing closure to exceptionHandler - Remove unnecessary closure conversion
guanguans · Aug 20, 2023 · 632baae · 632baae
1 parent 969916e
commit 632baae
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/ExceptionNotifyServiceProvider.php b/src/ExceptionNotifyServiceProvider.php
@@ -157,11 +157,11 @@ protected function extendExceptionHandler(): self
 
                 /** @var callable(\Throwable):mixed|void $reportUsing */
                 $reportUsing = $reportUsingCreator($exceptionHandler);
-                if (! $reportUsing instanceof \Closure) {
-                    $reportUsing = \Closure::fromCallable($reportUsing);
+                if ($reportUsing instanceof \Closure) {
+                    $reportUsing = $reportUsing->bindTo($exceptionHandler, $exceptionHandler);
                 }
 
-                $exceptionHandler->reportable($reportUsing->bindTo($exceptionHandler, $exceptionHandler));
+                $exceptionHandler->reportable($reportUsing);
             }
 
             return $exceptionHandler;