Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New effect: Bumper Peds #276

Open
wants to merge 1 commit into
base: 3.0
Choose a base branch
from

Conversation

gromchek
Copy link
Contributor

This effect disable run over a ped by a vehicle. Instead of it, the vehicle will push away from the ped.
However, the player can still be run over by vehicle.

@Lordmau5
Copy link
Member

If the car is being pushed away from the ped, shouldn't it much rather be called something else?
Concrete to me would make it sound like you hit a ped and the car just stops

@gromchek
Copy link
Contributor Author

I thought about it. While coding I decided to make car push away but didn't change the name.
Maybe "bump peds" would be more accurate

@Lordmau5
Copy link
Member

Hmm... "Pinball Peds" or "Bumper Peds" might be an idea, or maybe even "Rubber Peds"...

@gromchek
Copy link
Contributor Author

I think "Bumper Peds" is more accurate

@gromchek gromchek changed the title New effect: Concrete Peds New effect: Bumper Peds Aug 4, 2024
@Lordmau5
Copy link
Member

Lordmau5 commented Aug 5, 2024

I wonder if using the inst->Random method would be better than a static set of random Z-values?

Example here: https://github.com/gta-chaos-mod/Trilogy-ASI-Script/blob/3.0/src/gtasa/effects/custom/hud/ScreensaverHUDEffect.cpp#L123

You gotta make a copy of the instance (or reference rather) in the OnStart method and then you can use it in static methods, too

@Lordmau5 Lordmau5 added this to the 3.2.3 milestone Aug 5, 2024
@gromchek
Copy link
Contributor Author

gromchek commented Aug 8, 2024

I wonder if using the inst->Random method would be better than a static set of random Z-values?

I've tested random Z value but that didn't turn out to be much fun. So I've decided to use fixed Z value. 0.3f value is enough to "jump over" most of fences in the game.
Any way I will check this out. It might be a good idea to apply move force after collision.

@Lordmau5
Copy link
Member

Lordmau5 commented Aug 8, 2024

I've tested random Z value but that didn't turn out to be much fun. So I've decided to use fixed Z value. 0.3f value is enough to "jump over" most of fences in the game.

I don't think it needs to be higher, but I feel it can sometimes be lower to be honest - maybe 0.01 as well. So somewhere inbetween 0.01 and 0.3 maybe

Having the car just slide away is annoying as well, especially when you hit multiple peds after one another

@gromchek
Copy link
Contributor Author

gromchek commented Aug 8, 2024

Having the car just slide away is annoying as well, especially when you hit multiple peds after one another

Do you want to have an internal cooldown for pushing? Like 500-1000ms

@Lordmau5
Copy link
Member

Lordmau5 commented Aug 8, 2024

Having the car just slide away is annoying as well, especially when you hit multiple peds after one another

Do you want to have an internal cooldown for pushing? Like 500-1000ms

Nono, what I meant is that I think it's annoying in a funny way if the car is just sliding at times as well, compared to it bouncing on every hit

@gromchek
Copy link
Contributor Author

gromchek commented Aug 8, 2024

Ok, I changed to random value between 0.01f and 0.2f
Looks good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants