Refactor to directly call Platform.is and make .isWeb constant #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esDotDev
requested changes
Mar 4, 2022
lib/src/universal_platform_none.dart
Outdated
|
|
||
| abstract class UniversalPlatform { | ||
| static UniversalPlatformType get value => UniversalPlatform.current; | ||
| static UniversalPlatformType get current => UniversalPlatformType.None; |
There was a problem hiding this comment.
Are you sure this is correct? Why have both value and current? Why is current set to value, and none set to current?
There was a problem hiding this comment.
Hmmm, I was thinking of having .current as an alias to .value, but it might be unneeded. I'll remove it.
tqdv
force-pushed
the
master
branch
3 times, most recently
from
e38186e
to
165dcb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.