-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various analysis updates #755
Conversation
PR Health
Breaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
grpc | Breaking | 4.0.1 | 4.0.2-wip | 5.0.0 Got "4.0.2-wip" expected >= "5.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
.
Changelog Entry ❗
Package | Changed Files |
---|---|
package:grpc | README.md lib/grpc.dart lib/src/client/call.dart lib/src/client/http2_connection.dart lib/src/client/transport/xhr_transport.dart lib/src/server/handler.dart lib/src/shared/io_bits/io_bits_web.dart pubspec.yaml |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check
.
Coverage ⚠️
File | Coverage |
---|---|
lib/grpc.dart | 💔 Not covered |
lib/src/client/call.dart | 💚 85 % |
lib/src/client/http2_connection.dart | 💚 79 % |
lib/src/client/transport/xhr_transport.dart | 💔 Not covered |
lib/src/server/handler.dart | 💚 96 % |
lib/src/shared/io_bits/io_bits_web.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|---|
grpc | Any $1.Duration |
This check can be disabled by tagging the PR with skip-leaking-check
.
Co-authored-by: Moritz <[email protected]>
Just saw the analysis failures for |
👍 - done |
strict_top_level_inference
)topics
andfalse_secrets
sections of the pubspec file@mosuem