Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various analysis updates #755

Merged
merged 5 commits into from
Jan 30, 2025
Merged

various analysis updates #755

merged 5 commits into from
Jan 30, 2025

Conversation

devoncarew
Copy link
Contributor

  • various analysis updates (fix several items found with strict_top_level_inference)
  • fix indents for the topics and false_secrets sections of the pubspec file

@mosuem

Copy link

linux-foundation-easycla bot commented Jan 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

github-actions bot commented Jan 24, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
grpc Breaking 4.0.1 4.0.2-wip 5.0.0
Got "4.0.2-wip" expected >= "5.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry
Package Changed Files
package:grpc README.md
lib/grpc.dart
lib/src/client/call.dart
lib/src/client/http2_connection.dart
lib/src/client/transport/xhr_transport.dart
lib/src/server/handler.dart
lib/src/shared/io_bits/io_bits_web.dart
pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
lib/grpc.dart 💔 Not covered
lib/src/client/call.dart 💚 85 %
lib/src/client/http2_connection.dart 💚 79 %
lib/src/client/transport/xhr_transport.dart 💔 Not covered
lib/src/server/handler.dart 💚 96 %
lib/src/shared/io_bits/io_bits_web.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc Any
$1.Duration

This check can be disabled by tagging the PR with skip-leaking-check.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mosuem
Copy link
Contributor

mosuem commented Jan 29, 2025

Just saw the analysis failures for dart:html use - could you add a lint ignore with a TODO? Just want to make sure the main branch CI stays green.

@devoncarew
Copy link
Contributor Author

Just saw the analysis failures for dart:html use - could you add a lint ignore with a TODO? Just want to make sure the main branch CI stays green.

👍 - done

@mosuem mosuem merged commit 7f9042f into grpc:master Jan 30, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants